[PATCH] rbtree

From: Érsek László (erseklaszlo@chello.hu)
Date: Sun Nov 24 2002 - 17:41:06 EST


Hi all,

this patch tries to remove those checks for 0 from
linux-2.4.19/lib/rbtree.c which are (I think) superfluous.

Laszlo Ersek

--- linux-2.4.19/lib/rbtree.c Sat Aug 3 02:39:46 2002
+++ linux/lib/rbtree.c Sun Nov 24 22:59:38 2002
@@ -159,17 +159,16 @@
                                 if (!other->rb_right ||
                                     other->rb_right->rb_color == RB_BLACK)
                                 {
- register rb_node_t * o_left;
- if ((o_left = other->rb_left))
- o_left->rb_color = RB_BLACK;
+ /* unneeded check-for-0 removed */
+ other->rb_left->rb_color = RB_BLACK;
                                         other->rb_color = RB_RED;
                                         __rb_rotate_right(other, root);
                                         other = parent->rb_right;
                                 }
                                 other->rb_color = parent->rb_color;
                                 parent->rb_color = RB_BLACK;
- if (other->rb_right)
- other->rb_right->rb_color = RB_BLACK;
+ /* unneeded check-for-0 removed */
+ other->rb_right->rb_color = RB_BLACK;
                                 __rb_rotate_left(parent, root);
                                 node = root->rb_node;
                                 break;
@@ -199,17 +198,16 @@
                                 if (!other->rb_left ||
                                     other->rb_left->rb_color == RB_BLACK)
                                 {
- register rb_node_t * o_right;
- if ((o_right = other->rb_right))
- o_right->rb_color = RB_BLACK;
+ /* unneeded check-for-0 removed */
+ other->rb_right->rb_color = RB_BLACK;
                                         other->rb_color = RB_RED;
                                         __rb_rotate_left(other, root);
                                         other = parent->rb_left;
                                 }
                                 other->rb_color = parent->rb_color;
                                 parent->rb_color = RB_BLACK;
- if (other->rb_left)
- other->rb_left->rb_color = RB_BLACK;
+ /* unneeded check-for-0 removed */
+ other->rb_left->rb_color = RB_BLACK;
                                 __rb_rotate_right(parent, root);
                                 node = root->rb_node;
                                 break;

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Nov 30 2002 - 22:00:10 EST