Re: [BUG] [2.5.49] symbol_get doesn't work

From: Rusty Russell (rusty@rustcorp.com.au)
Date: Tue Nov 26 2002 - 18:27:33 EST

Next message: Rusty Russell: "Re: Patch?: module-init-tools/modprobe.c - use modules.dep"
Previous message: Greg KH: "Re: hugetlbpage.c build failure?"
In reply to: Wang, Stanley: "[BUG] [2.5.49] symbol_get doesn't work"
Next in thread: Rusty Lynch: "Re: [BUG] [2.5.49] symbol_get doesn't work"
Reply: Rusty Lynch: "Re: [BUG] [2.5.49] symbol_get doesn't work"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

In message <957BD1C2BF3CD411B6C500A0C944CA2601F11696@pdsmsx32.pd.intel.com> you
write:
> Hello,
> I found the symbol_get()/symbol_put() didn't work on my 2.5.49 build.
> I think the root cause is a wrong macro definition. The following patch
> could
> fix this bug.

Hi Wang,

Thanks for the bug report, but I think you misunderstand.
symbol_get() does not take a string, it takes an identifier. This
way, we can ensure the type is correct. eg.

/* In header somewhere. */
extern int their_integer;

        ....
                int *ptr = symbol_get(their_integer);
                if (!ptr) ...

Does that help?
Rusty.

--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: Rusty Russell: "Re: Patch?: module-init-tools/modprobe.c - use modules.dep"
Previous message: Greg KH: "Re: hugetlbpage.c build failure?"
In reply to: Wang, Stanley: "[BUG] [2.5.49] symbol_get doesn't work"
Next in thread: Rusty Lynch: "Re: [BUG] [2.5.49] symbol_get doesn't work"
Reply: Rusty Lynch: "Re: [BUG] [2.5.49] symbol_get doesn't work"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sat Nov 30 2002 - 22:00:18 EST