Re: [PATCH] create_proc_read_entry in arch/ppc/iSeries/rtc.c

From: Rusty Russell (rusty@rustcorp.com.au)
Date: Sun Dec 01 2002 - 23:47:35 EST

In message <Pine.LNX.4.44.0211181909260.15091-200000@top.qwarx.com> you write:
> This message is in MIME format. The first part should be readable text,
> while the remaining parts are likely unreadable without MIME-aware tools.
> Send mail to mime@docserver.cac.washington.edu for more info.
>
> ---1044231485-1031583466-1037559336=:16702
> Content-Type: TEXT/PLAIN; CHARSET=US-ASCII
> Content-ID: <Pine.LNX.4.44.0211171855531.16702@top.qwarx.com>
>
> Dear Sir,
>
> As part of the Linux Kernel Janitors audit of misc_register usage,
> I would like to submit my related patch to arch/ppc/iSeries/rtc.c.

> --- linux-2.5.47/arch/ppc/iSeries/rtc.c Mon Nov 11 03:28:15 2002
> +++ linux-2.5.47-chris/arch/ppc/iSeries/rtc.c Sun Nov 17 21:29:25 2002
> static int __init rtc_init(void)
> {
> - if (misc_register(&rtc_dev))
> + if (misc_register(&rtc_dev)) {
> + printk(KERN_ERR "iSeries-rtc: cannot register misc device.\n");
> return -ENODEV;
> - create_proc_read_entry ("driver/rtc", 0, 0, rtc_read_proc, NULL);
> + }

But this cannot sanely fail (it cannot be a module). It's probably
better to do something like inserting a check inside misc_register and
create_proc_read_entry:

        BUG_ON(booting && failed);

Maybe even create a "NOFAIL_ON_BOOT(condition)" which does this for
you.

Thoughts?
Rusty. 

--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Sat Dec 07 2002 - 22:00:12 EST