Re: [PATCH] PCI Hotplug changes for 2.5.50

From: Greg KH (greg@kroah.com)
Date: Mon Dec 02 2002 - 03:26:08 EST


ChangeSet 1.924.3.2, 2002/11/30 01:18:05-08:00, adam@yggdrasil.com

[PATCH] Patch/resubmit(2.5.50): Eliminate pci_dev.driver_data

        To review, this patch deletes pci_dev.driver_data, using the
existing pci_dev.device.driver_data field instead, thereby shrinking
struct pci_dev by four bytes on 32-bit machines. The few device
drivers that attempted to directly reference pci_dev.driver_data were
fixed in a patch of mine that Jeff Garzik got into 2.5.45. Also,
making this change should help with memory allocation improvements in
the future, although that's a separate issue.

diff -Nru a/include/linux/pci.h b/include/linux/pci.h
--- a/include/linux/pci.h Sun Dec 1 23:26:24 2002
+++ b/include/linux/pci.h Sun Dec 1 23:26:24 2002
@@ -344,7 +344,6 @@
         u8 rom_base_reg; /* which config register controls the ROM */
 
         struct pci_driver *driver; /* which driver has allocated this device */
- void *driver_data; /* data private to the driver */
         u64 dma_mask; /* Mask of the bits of bus address this
                                            device implements. Normally this is
                                            0xffffffff. You only need to change
@@ -753,12 +752,12 @@
  */
 static inline void *pci_get_drvdata (struct pci_dev *pdev)
 {
- return pdev->driver_data;
+ return pdev->dev.driver_data;
 }
 
 static inline void pci_set_drvdata (struct pci_dev *pdev, void *data)
 {
- pdev->driver_data = data;
+ pdev->dev.driver_data = data;
 }
 
 /*
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Dec 07 2002 - 22:00:12 EST