Re:Linux 2.4.18 8139too.c driver fix for mii-tool

From: Felipe W Damasio (felipewd@terra.com.br)
Date: Mon Dec 02 2002 - 11:25:44 EST

---------- Cabeçalho inicial -----------

De: linux-kernel-owner@vger.kernel.org
Para: linux-kernel@vger.kernel.org
Cópia:
Data: Mon, 02 Dec 2002 08:11:52 -0800
Assunto: Linux 2.4.18 8139too.c driver fix for mii-tool

> The fix is to change the masking done in the top of netdev_ioctl:
> if (cmd != SIOCETHTOOL) {
> /* With SIOCETHTOOL, this would corrupt the pointer. */
> data->phy_id &= 0x3f; // was 0x1f (DA) 20021202
> data->reg_num &= 0x1f;
> }

  In 2.4.20, the non-ethtool ioctls on 8139too (and 8139cp, for that
matter) are handled by mii.c::generic_mii_ioctl, which already have
this fix (in a more generic way):

mii_data->phy_id &= mii_if->phy_id_mask;
mii_data->reg_num &= mii_if->reg_num_mask;

  You can check

http://www.kernel.org/diff/diffview.cgi?css=%2Fdiff%2Fdiff.css;file=%2Fpub%2Flinux%2Fkernel%2Fv2.4%2Fpatch-2.4.20.gz;z=1765

  For more details.

  Kind Regards,

Felipe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Sat Dec 07 2002 - 22:00:13 EST