On Wed, 4 Dec 2002, Stephen Rothwell wrote:
>
> To use this,an architecture must create asm/compat.h and provide typedefs
> for (currently) compat_time_t, compat_suseconds_t, struct compat_timespec.
Ok, this looks fine to me. At this point my only issues are purely
cosmetic, namely that "suseconds" thing made me go "wtf?". I have _never_
actually seen it used, it's one of those stupid typedefs that have no
point to them.
Since the only use of "suseconds" is in the "compat_timeval" definition,
and since you already have a "compat_timespec", my reaction is to ask why
we don't just make "compat_timeval" be the arch-supplied typedef, and drop
that strange "suseconds" thing entirely?
That avoids a very awkward name, _and_ it looks more natural to pair
compat_timeval and compat_timespec anyway.
(Yeah, I know we use suseconds_t in the "real" timeval declaration, and I
think that's strange too.)
I'll do that change by hand, and apply this to get the ball rolling, ok?
Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Sat Dec 07 2002 - 22:00:19 EST