Re: [PATCH] NMI notifiers for 2.5

From: John Levon (levon@movementarian.org)
Date: Wed Dec 04 2002 - 14:01:38 EST

Next message: Larry Sendlosky: "RE: [PATCH] NMI notifiers for 2.5"
Previous message: XI: "Re: Ctrl-Alt-Backspace kills machine not X. ACPI?"
In reply to: Stephen Hemminger: "[PATCH] NMI notifiers for 2.5"
Next in thread: Larry Sendlosky: "RE: [PATCH] NMI notifiers for 2.5"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Wed, Dec 04, 2002 at 10:39:02AM -0800, Stephen Hemminger wrote:

> +/*
> + * Registration for maintance routines that want to do something
> + * on NMI.
> + */
> +extern struct notifier_block *nmi_notifier_list;
> +static inline int register_nmi_notifier(struct notifier_block *nb) {
> + return notifier_chain_register(&nmi_notifier_list, nb);
> +}

Easy way to confuse the hell out of people...

> +
> + notifier_call_chain(&nmi_notifier_list, 0, regs);
> +

... because it's really a lockup detect notifier. Please rethink the
naming

(oh and maintenance not maintance)

regards
john

-- 
"Trolls like content too."
	- Bob Abooey, /.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: Larry Sendlosky: "RE: [PATCH] NMI notifiers for 2.5"
Previous message: XI: "Re: Ctrl-Alt-Backspace kills machine not X. ACPI?"
In reply to: Stephen Hemminger: "[PATCH] NMI notifiers for 2.5"
Next in thread: Larry Sendlosky: "RE: [PATCH] NMI notifiers for 2.5"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sat Dec 07 2002 - 22:00:19 EST