Re: [2.5.50, ACPI] link error

From: Shawn Starr (shawn.starr@datawire.net)
Date: Wed Dec 04 2002 - 16:05:11 EST


Thats what I thought until Pavel told me SOFTWARE_SUSPEND requires ACPI_SLEEP
and ACPI_SLEEP should not be unchecked if SOFTWARE_SUSPEND is disabled.

My patch was only to fix a link error in 2.5.49/50. A better solution is
needed :-)

Shawn.

>List: linux-kernel
>Subject: Re: [2.5.50, ACPI] link error
From: Roman Zippel <zippel@linux-m68k.org>
>Date: 2002-12-04 20:29:08
>[Download message RAW]
>
>Hi,
>
>On Wed, 4 Dec 2002, Adrian Bunk wrote:
>
> In drivers/acpi/Config.in in 2.5.44:
>
> <-- snip -->
>
> ...
> if [ "$CONFIG_ACPI_HT_ONLY" != "y" ]; then
> bool ' Sleep States' CONFIG_ACPI_SLEEP
> ...
> define_bool CONFIG_ACPI_SLEEP $CONFIG_SOFTWARE_SUSPEND
> ...
> fi
> ...
>
> <-- snip -->
>
>
> This double definition was at least confusing, a simple
>
> dep_bool ' Sleep States' CONFIG_ACPI_SLEEP $CONFIG_SOFTWARE_SUSPEND
>
> would have expressed it better.

>It's not really the same and the first probably heavily confuses xconfig.
>If CONFIG_SOFTWARE_SUSPEND can do without CONFIG_ACPI_SLEEP, the second
>version should work fine.

> config ACPI_SLEEP
> bool "Sleep States"
> - depends on X86 && ACPI && !ACPI_HT_ONLY
> + depends on X86 && ACPI && !ACPI_HT_ONLY && SOFTWARE_SUSPEND
> default SOFTWARE_SUSPEND
> ---help---
> This option adds support for ACPI suspend states.

>The default is probably not needed anymore.

-- 
Shawn Starr
UNIX Systems Administrator, Operations
Datawire Communication Networks Inc.
10 Carlson Court, Suite 300
Toronto, ON, M9W 6L2
T: 416-213-2001 ext 179  F: 416-213-2008
shawn.starr@datawire.net
"The power to Transact" - http://www.datawire.net

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Dec 07 2002 - 22:00:20 EST