Re: [PATCH] compatibility syscall layer (lets try again)

From: Richard Henderson (rth@twiddle.net)
Date: Thu Dec 05 2002 - 19:03:53 EST


On Thu, Dec 05, 2002 at 08:35:18AM -0800, george anzinger wrote:
> +asmlinkage long
> +sys_restart_syscall( void *parm)
> +{
> + if ( ! current_thread_info()->restart_block.fun){
> + return current_thread_info()->restart_block.fun(&parm);
> + }

(1) Address of parameter?
(2) Passing in such parameters unchecked is a security hole.
(3) Much easier to just take all information from restart_block
    instead of pushing it into the fake syscall.
(4) Should probably clear restart_block.fun immediately.

r~
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Dec 07 2002 - 22:00:24 EST