Re: [Linux-fbdev-devel] [PATCH 1/3: FBDEV: VGA State Save/Restore module

From: James Simmons (jsimmons@infradead.org)
Date: Thu Dec 05 2002 - 19:53:41 EST


> > One thing I like to suggest. I like to move the vga code in fb.h to vga.h.
> > Alot of fbdev devices don't have a VGA core.
> >
> >
>
> Only the structure definition of fb_vgastate is in fb.h. For drivers
> without a vga core, they'll just won't link to it and it won't be
> compiled. Plus, vga.h is not a common header (not located in
> include/asm or include/linux) and it contains a lot of declarations and
> definitions which are irrelevant to most drivers or are already
> duplicated. This will be messier, I think.

I like to move vga.h to include/video. And yes I like to clean it up. The
reason is I like to implement the function in vga.h and some in vgastate
into vgacon.c. It would be nice if vgacon could support different hardware
states per VC instead of changing every virtual console for everything.
The other dream is I like to see vgacon become firmware independent.

> Maybe we can just enclose it in a macro, something like:
>
> #ifdef FBDEV_HAS_VGACORE
> ...
> #endif
 
Yuck :-(

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Dec 07 2002 - 22:00:25 EST