Re: [PATCH] Make `hash_long' function work if bits parameter is 0.

• Next message: Matthew Wilcox: "Re: [RFC] generic device DMA implementation"
• Previous message: Ralf Hildebrandt: "Re: linux-2.4.20 fails to build with aic7xxx"
• In reply to: Miles Bader: "[PATCH] Make `hash_long' function work if bits parameter is 0."
• Next in thread: Miles Bader: "Re: [PATCH] Make `hash_long' function work if bits parameter is 0."
• Reply: Miles Bader: "Re: [PATCH] Make `hash_long' function work if bits parameter is 0."
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Fri, 6 Dec 2002, Miles Bader wrote:
>
> If the bits parameter of hash_long (in <linux/hash.h>) is 0, then it
> ends up right-shifting by BITS_PER_LONG, which is undefined in C (and
> often is a nop).

I would much rather just add a comment saying that "bits" had better be in
a valid range. There are no valid uses for a 0-bit hash table that I can
see, and undefined behaviour for undefined operations is fine with me.

                Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

• Next message: Matthew Wilcox: "Re: [RFC] generic device DMA implementation"
• Previous message: Ralf Hildebrandt: "Re: linux-2.4.20 fails to build with aic7xxx"
• In reply to: Miles Bader: "[PATCH] Make `hash_long' function work if bits parameter is 0."
• Next in thread: Miles Bader: "Re: [PATCH] Make `hash_long' function work if bits parameter is 0."
• Reply: Miles Bader: "Re: [PATCH] Make `hash_long' function work if bits parameter is 0."
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sat Dec 07 2002 - 22:00:27 EST