Linus Torvalds wrote:
>
> On Fri, 6 Dec 2002, Jim Houston wrote:
> >
> > I know it would be a few extra lines of assembly code but it would be
> > nice if the restart routine had the original arguments.
>
> It's not even extra code on x86, since we don't stomp on any of the
> arguments, and they will all have the same values when returning. So on
> x86, we could see the arguments by just adding parameters to the
> sys_restart_syscall() function.
>
Would you consider this small change?
-- George Anzinger george@mvista.com High-res-timers: http://sourceforge.net/projects/high-res-timers/ Preemption patch: http://www.kernel.org/pub/linux/kernel/people/rml
--- linux-2.5.50-bk4-hrposix/arch/i386/kernel/signal.c Fri Dec 6 18:17:06 2002 +++ linux/arch/i386/kernel/singnal.c Fri Dec 6 18:20:05 2002 @@ -507,8 +507,8 @@ /* If so, check system call restarting.. */ switch (regs->eax) { case -ERESTART_RESTARTBLOCK: - current_thread_info()->restart_block.fn = do_no_restart_syscall; case -ERESTARTNOHAND: + current_thread_info()->restart_block.fn = do_no_restart_syscall; regs->eax = -EINTR; break;
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Sat Dec 07 2002 - 22:00:28 EST