Re: [BK][PATCH] ReiserFS CPU and memory bandwidth efficient large writes

From: Chris Mason (mason@suse.com)
Date: Mon Dec 16 2002 - 13:24:28 EST


On Sat, 2002-12-14 at 15:25, Oleg Drokin wrote:

> reiserfs v3 was traditionally hungry on stack space I think.

Well, if you want to drop stack usage, kill some inlines from stree.c.
I really doubt we gain anything from inlining these:

--- linux/fs/reiserfs/stree.c.1 Tue Sep 24 09:50:50 2002
+++ linux/fs/reiserfs/stree.c Tue Sep 24 09:51:18 2002
@@ -340,7 +340,7 @@
 

 /* Get delimiting key of the buffer at the path and its right neighbor. */
-inline const struct key * get_rkey (
+const struct key * get_rkey (
                         const struct path * p_s_chk_path,
                         const struct super_block * p_s_sb
                       ) {
@@ -925,7 +925,7 @@
 

 // prepare for delete or cut of direct item
-static inline int prepare_for_direct_item (struct path * path,
+static int prepare_for_direct_item (struct path * path,
                                            struct item_head * le_ih,
                                            struct inode * inode,
                                            loff_t new_file_length,
@@ -970,7 +970,7 @@
 }
 

-static inline int prepare_for_direntry_item (struct path * path,
+static int prepare_for_direntry_item (struct path * path,
                                              struct item_head * le_ih,
                                              struct inode * inode,
                                              loff_t new_file_length,

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Dec 23 2002 - 22:00:14 EST