Re: [patch 2.5] PCI: kill pdev_enable_device()

From: Dave Jones (davej@codemonkey.org.uk)
Date: Tue Dec 17 2002 - 19:42:26 EST

On Tue, Dec 17, 2002 at 05:31:57PM -0500, Jeff Garzik wrote:
> Ivan Kokshaysky wrote:
> >- So, if we don't touch the PCI command registers, there is no point in
> > using pdev_enable_device(). Most drivers properly use
> > pci_enable_device() anyway.
> Not only that, a driver _should_ be calling pci-enable-device, it's an
> API requirement. J Random Driver should have a good reason _not_ to
> call pci_enable_device() ...

What about the xircom issue that was discussed in the last days ?
Sounds like the solution isn't a full on pci_enable_device() as
pcmcia 'knows better than us' at that stage aparently.

                Dave 

-- 
| Dave Jones.        http://www.codemonkey.org.uk
| SuSE Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Mon Dec 23 2002 - 22:00:18 EST