pr_debug() and #define DEBUG usage

• Next message: Jochen Friedrich: "Re: [PATCH] 2.5.52: compilation fixes for alpha"
• Previous message: Ralf Hildebrandt: "2.4.21-pre2 assertion errer in af_inet.c/tcp.c"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Hi,

Some drivers, filesystems, subsystems, and libraries #define or use
DEBUG locally in their source files. This can conflict with DEBUG
in include/linux/kernel.h, specifically the "pr_debug" macro, which
has over 300 uses (invocations, calls) in 2.5.52 spread throughout
drivers, libraries, and filesystems.

Question:
How should DEBUG be enabled for use by include/linux/kernel.h ?
a. change CFLAGS_KERNEL in linux/Makefile to include "-DDEBUG"
b. #define DEBUG in include/linux/kernel.h
c. #define DEBUG in each file where someone wants to enable it
d. others?

"DEBUG" seems heavily used (or overused, misused, abused) and too
generic.

And in one place, it keeps a kernel build from completing when
DEBUG is defined. In lib/inflate.c, line 999:
  fprintf(stderr, "<%u> ", h);
gcc just doesn't like this line.

-- 
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

• Next message: Jochen Friedrich: "Re: [PATCH] 2.5.52: compilation fixes for alpha"
• Previous message: Ralf Hildebrandt: "2.4.21-pre2 assertion errer in af_inet.c/tcp.c"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Mon Dec 23 2002 - 22:00:26 EST