Re: [RESEND][PATCH] better compat_jiffies_to_clock_t

From: Linus Torvalds (torvalds@transmeta.com)
Date: Mon Dec 23 2002 - 00:14:07 EST


On Mon, 23 Dec 2002, Stephen Rothwell wrote:
>
> At David Mosberger's suggestion can we use this new version of
> compat_jiffies_to_clock_t? It does better rounding and will not fail
> if COMPAT_USER_HZ > HZ.

I don't like using "long long" and divisions.

Since this code is currently only used for 64-bit targets, is there any
reason to use "long long" at all, and not just use "long"? I can see a
64-bit target where "long long" would be 128 bits, and this would do the
wrong thing.

                Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Dec 23 2002 - 22:00:31 EST