Re: [ACPI] [PATCH] acpi_wakeup fixes

From: Pavel Machek (pavel@suse.cz)
Date: Sat Dec 21 2002 - 07:01:02 EST

Next message: Tim Pepper: "ext3/jbd breaks md stacking in 2.4"
Previous message: Roy Sigurd Karlsbakk: "Fwd: [Asterisk] intermittent i4l problems"
In reply to: Ducrot Bruno: "[PATCH] acpi_wakeup fixes"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Hi!

> @@ -41,7 +41,7 @@
> cmpl _0x12345678, %eax
> jne bogus_real_magic
>
> -#if 1
> +#if 0
> lcall _0xc000,_3
> #endif
> #if 0

We should make this runtime configurable...

Anyway disabling this is probably right.

> @@ -69,8 +69,12 @@
>
> movl real_save_cr0 - wakeup_code, %eax
> movl %eax, %cr0
> +
> + # flush the prefetch queue.
> jmp 1f
> +1: jmp 1f
> 1:

Is this really neccessary? One jump should be
ok...

> @@ -160,11 +164,12 @@
> ALIGN
>
>
> -.org 0x2000
> +.org 0x800
> wakeup_stack:
> -.org 0x3000
> +.org 0x900
> ENTRY(wakeup_end)
> -.org 0x4000
> +# .org 0x1000
> + .align 4096

Kill the comment, otherwise ok.

> wakeup_pmode_return:
> movl ___KERNEL_DS, %eax

-- Pavel Written on sharp zaurus, because my Velo1 broke. If you have Velo you don't need...

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Next message: Tim Pepper: "ext3/jbd breaks md stacking in 2.4"
Previous message: Roy Sigurd Karlsbakk: "Fwd: [Asterisk] intermittent i4l problems"
In reply to: Ducrot Bruno: "[PATCH] acpi_wakeup fixes"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Mon Dec 23 2002 - 22:00:32 EST