>
>
>
> skblen = skb->len;
>
>- save_flags(flags);
>- cli();
>+ local_irq_save(flags);
>
>
This would be the wrong thing (tm) for SMP: cli() gives a compile error
for SMP, local_irq_save() creates the impression that the driver works
on SMP systems. m68k is UP only, thus there is no need to fix it properly.
What about adding
+ #ifdef CONFIG_SMP
+ #error This driver does not work on SMP
+ #endif
Or a Kconfig dependency on !CONFIG_SMP?
-- Manfred- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Tue Dec 31 2002 - 22:00:11 EST