Re: [PATCH] PATCH: IPMI driver

From: Dave Jones (davej@codemonkey.org.uk)
Date: Thu Jan 09 2003 - 14:20:22 EST

Next message: Alan Cox: "Re: MB without keyboard controller / USB-only keyboard ?"
Previous message: Greg KH: "[BK PATCH] USB changes for 2.5.55"
In reply to: Corey Minyard: "Re: [PATCH] PATCH: IPMI driver"
Next in thread: Alan Cox: "Re: [PATCH] PATCH: IPMI driver"
Reply: Alan Cox: "Re: [PATCH] PATCH: IPMI driver"
Reply: Corey Minyard: "Re: [PATCH] PATCH: IPMI driver"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Thu, Jan 09, 2003 at 01:16:29PM -0600, Corey Minyard wrote:

> >Pull the 2.5 port from openipmi.sourceforge.net saves you doing the port
> >yourself.
> >
> Definately pull the 2.5 port from there, as there are some differences
> between the 2.4 and 2.5 versions.

I had a quick skim through the patch.
Is the handling of jiffies wraps done correctly ? It doesn't
look like it...

time_diff = ((jiffies_now - kcs_info->last_timeout_jiffies)

Dave

-- 
| Dave Jones.        http://www.codemonkey.org.uk
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: Alan Cox: "Re: MB without keyboard controller / USB-only keyboard ?"
Previous message: Greg KH: "[BK PATCH] USB changes for 2.5.55"
In reply to: Corey Minyard: "Re: [PATCH] PATCH: IPMI driver"
Next in thread: Alan Cox: "Re: [PATCH] PATCH: IPMI driver"
Reply: Alan Cox: "Re: [PATCH] PATCH: IPMI driver"
Reply: Corey Minyard: "Re: [PATCH] PATCH: IPMI driver"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Wed Jan 15 2003 - 22:00:29 EST