Re: [Linux-fbdev-devel] Re: xxx_check_var

From: James Simmons (jsimmons@infradead.org)
Date: Thu Jan 09 2003 - 21:29:45 EST


> > > Yes, this wrong, and afaik, it's your original port to 2.5 that did that
> > > ;)
> >
> > Yeap. The idea of check_var is to validate a mode. Note modedb uses just
> > check_var. It is okay to READ the values in your par. You shouldn't alter
> > the values in par.
>
> Perhaps it makes sense to make the info parameter of fb_check_var() const to
> prevent this from happening?

Easy fix. I can whip up a quick patch for that.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Wed Jan 15 2003 - 22:00:31 EST