In message <20030107063239.F1ED73745@mcspd15.ucom.lsi.nec.co.jp> you write:
> Since these are just symbols in the module object, they need symbol name
> munging to find the symbol from the parameter name.
Good point. Linus, please apply.
> [I guess using the stack is bad in general, but parameter names should be
> very short, and hey if they're obsolete, it seems pointless to spend
> much effort.]
Should be fine here. I removed the spaces between the funcname and
the brackets tho.
Thanks!
Rusty.
-- Anyone who quotes me in their sig is an idiot. -- Rusty Russell.Name: Make obsolete module parameters work with MODULE_SYMBOL_PREFIX Author: Miles Bader Status: Trivial
D: Since these are just symbols in the module object, they need symbol name D: munging to find the symbol from the parameter name.
diff -ruN -X../cludes linux-2.5.54-moo.orig/kernel/module.c linux-2.5.54-moo/kernel/module.c --- linux-2.5.54-moo.orig/kernel/module.c 2003-01-06 10:51:20.000000000 +0900 +++ linux-2.5.54-moo/kernel/module.c 2003-01-07 14:31:53.000000000 +0900 @@ -666,13 +666,18 @@ num, obsparm[i].name, obsparm[i].type); for (i = 0; i < num; i++) { + char sym_name[strlen(obsparm[i].name) + 2]; + + strcpy(sym_name, MODULE_SYMBOL_PREFIX); + strcat(sym_name, obsparm[i].name); + kp[i].name = obsparm[i].name; kp[i].perm = 000; kp[i].set = set_obsolete; kp[i].get = NULL; obsparm[i].addr = (void *)find_local_symbol(sechdrs, symindex, strtab, - obsparm[i].name); + sym_name); if (!obsparm[i].addr) { printk("%s: falsely claims to have parameter %s\n", name, obsparm[i].name); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Wed Jan 15 2003 - 22:00:31 EST