Re: [PATCH 2.5.56] Sound core not compiling without /proc support

From: Sam Ravnborg (sam@ravnborg.org)
Date: Sun Jan 12 2003 - 07:56:45 EST


On Sun, Jan 12, 2003 at 01:00:40PM +0100, Paul Rolland wrote:
> Hello,
>
> Here is a quick patch to allow sound support to compile correctly
> when not using /proc support.

You are making all users of functions manipulating /proc condentional.
A simpler approach would be to make the functions that actually
minipulate /proc conditional.
For example snd_info_card_create() could be a noop if CONFIG_PROC_FS
is not defined.
Then you minimize the number of #ifdef's, and they are placed logically
where they belongs.

Furhtermore you make less code conditional which imply that the execution
path - and thus code getting more test - is more similar for the two cases.

        Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Wed Jan 15 2003 - 22:00:40 EST