Re: [PATCH] 2.5.56-bug

From: Ingo Oeser (ingo.oeser@informatik.tu-chemnitz.de)
Date: Sun Jan 12 2003 - 18:49:40 EST

Next message: Rusty Russell: "[PATCH] __cacheline_aligned_in_smp?"
Previous message: Ingo Oeser: "Re: [RFC] Consolidate vmlinux.lds.S files"
In reply to: Russell King: "[PATCH] 2.5.56-bug"
Next in thread: Russell King: "Re: [PATCH] 2.5.56-bug"
Reply: Russell King: "Re: [PATCH] 2.5.56-bug"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Hi Russell,
Hi LKML,

On Sun, Jan 12, 2003 at 12:15:29PM +0000, Russell King wrote:
> This patch appears not to be in 2.5.56, but applies cleanly.
>
> This patch moves BUG() and PAGE_BUG() from asm/page.h into asm/bug.h.

While we are at it: BUG() expects the offending task to be killed
so implementations, which just do a printk() there are
non-conforming.

Code paths which contain BUG() or BUG_ON() usally expect this
code-path to end and just threat the opposite condition to be
true.

A conforming implementation is panic(), if faulting is not that
easy in these architectures, but printk() is just plain wrong.

Mind to get a patch on top of your doing exactly this
modification?

Regards

Ingo Oeser

-- 
Science is what we can tell a computer. Art is everything else. --- D.E.Knuth
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: Rusty Russell: "[PATCH] __cacheline_aligned_in_smp?"
Previous message: Ingo Oeser: "Re: [RFC] Consolidate vmlinux.lds.S files"
In reply to: Russell King: "[PATCH] 2.5.56-bug"
Next in thread: Russell King: "Re: [PATCH] 2.5.56-bug"
Reply: Russell King: "Re: [PATCH] 2.5.56-bug"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Wed Jan 15 2003 - 22:00:44 EST