Re: [PATCH] __cacheline_aligned_in_smp?

From: David S. Miller (davem@redhat.com)
Date: Mon Jan 13 2003 - 02:35:13 EST


   From: Rusty Russell <rusty@rustcorp.com.au>
   Date: Mon, 13 Jan 2003 18:24:40 +1100

   Dave: Anton suggested you might have a justification for
   __cacheline_aligned doing something on UP?
   
   I think I'd prefer __cacheline_aligned to be the same as
   __cacheline_aligned_in_smp, and have a new __cacheline_aligned_always
   for those who REALLY want it (if any).
   
I think things like oprofile_buffer really want it always.

   -struct tcp_hashinfo __cacheline_aligned tcp_hashinfo = {
   +struct tcp_hashinfo __cacheline_aligned_in_smp tcp_hashinfo = {

This definitely too.

All of the submembers are placed at cacheline boundaries, which
helps even on UP. If I meant cacheline aligned on SMP I would
have used the corresponding macro :)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Wed Jan 15 2003 - 22:00:44 EST