Re: Linux v2.5.58

From: Adrian Bunk (bunk@fs.tum.de)
Date: Tue Jan 14 2003 - 02:55:35 EST

On Mon, Jan 13, 2003 at 10:14:29PM -0800, Linus Torvalds wrote:
>...
> Summary of changes from v2.5.57 to v2.5.58
> ============================================
>...
> Dominik Brodowski <linux@brodo.de>:
>...
> o cpufreq: per-CPU initialization
>...

This change broke the compilation of several cpufreq drivers:

<-- snip -->

...
  gcc -Wp,-MD,arch/i386/kernel/cpu/cpufreq/.powernow-k6.o.d -D__KERNEL__
-Iinclude -Wall -Wstrict-prototypes -Wno-trigraphs -O2
-fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2
-march=k6 -Iinclude/asm-i386/mach-default -nostdinc -iwithprefix include
-DKBUILD_BASENAME=powernow_k6 -DKBUILD_MODNAME=powernow_k6 -c -o
arch/i386/kernel/cpu/cpufreq/powernow-k6.o
arch/i386/kernel/cpu/cpufreq/powernow-k6.c
arch/i386/kernel/cpu/cpufreq/powernow-k6.c:230: macro
`cpufreq_unregister' used without args
make[3]: *** [arch/i386/kernel/cpu/cpufreq/powernow-k6.o] Error 1

<-- snip -->

It seems the following was intended:

--- linux-2.5.58/include/linux/cpufreq.h.old 2003-01-14 08:53:27.000000000 +0100
+++ linux-2.5.58/include/linux/cpufreq.h 2003-01-14 08:53:56.000000000 +0100
@@ -130,7 +130,7 @@
 int cpufreq_unregister_driver(struct cpufreq_driver *driver_data);
 /* deprecated */
 #define cpufreq_register(x) cpufreq_register_driver(x)
-#define cpufreq_unregister(x) cpufreq_unregister_driver(NULL)
+#define cpufreq_unregister() cpufreq_unregister_driver(NULL)
 
 
 void cpufreq_notify_transition(struct cpufreq_freqs *freqs, unsigned int state);

cu
Adrian 

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Wed Jan 15 2003 - 22:00:49 EST