On Tue January 14 2003 19:13, ryan wrote:
>
> diff -urN a/sound/oss/sb_mixer.c b/sound/oss/sb_mixer.c
> --- a/sound/oss/sb_mixer.c Fri Jan 10 15:11:27 2003
> +++ b/sound/oss/sb_mixer.c Tue Jan 14 22:06:20 2003
> @@ -333,6 +333,9 @@
> break;
>
> default:
> + /* bounds check */
> + if (dev >= sizeof(smw_mix_regs))
> + return -EINVAL;
> reg = smw_mix_regs[dev];
> if (reg == 0)
> return -EINVAL;
Yup.
It would be better to do:
if (dev < 0 || dev >= ARRAY_SIZE(smw_mix_regs))
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Wed Jan 15 2003 - 22:00:53 EST