On Sun, Feb 09, 2003 at 03:07:27PM +0100, Mikael Pettersson wrote:
> I don't like the idea of registering apic_driver when !cpu_has_apic,
> but it might be needed for the local-APIC NMI watchdog.
Really ?
> >+#define NMI_LOCAL_APIC_SUSPENDED_BY_OPROFILE 4
>
> This is ugly like h*ll. Surely oprofile could just do:
>
> static unsigned int prev_nmi_watchdog;
> ..
> prev_nmi_watchdog = nmi_watchdog;
as long as it's exported to modules. I'd probably prefer
to just have :
disable_nmi_watchdog();
...
enable_nmi_watchdog();
and have those do the right thing depending on a (nmi.c local)
nmi_watchdog.
regards,
john
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Sat Feb 15 2003 - 22:00:22 EST