Re: [PATCH] 2.5.59 : drivers/char/ite_gpio.c

From: Rusty Russell (rusty@rustcorp.com.au)
Date: Sun Feb 09 2003 - 19:29:30 EST

Next message: Rusty Russell: "Re: [PATCH] 2.5.59 : drivers/char/ip2/i2lib.c"
Previous message: Rusty Russell: "re: smctr patch (with no subect)"
Next in thread: Horst von Brand: "Re: [PATCH] 2.5.59 : drivers/char/ite_gpio.c"
Reply: Horst von Brand: "Re: [PATCH] 2.5.59 : drivers/char/ite_gpio.c"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

In message <Pine.LNX.4.44.0302071217520.6917-100000@master> you write:
> --- linux/drivers/char/ite_gpio.c.old 2003-01-16 21:22:23.000000000 -0500
> +++ linux/drivers/char/ite_gpio.c 2003-02-07 02:04:43.000000000 -0500
> @@ -140,7 +140,7 @@
> {
> int ret=-1;
>
> - if (MAX_GPIO_LINE > *data >= 0)
> + if ((MAX_GPIO_LINE > *data) && (*data >= 0))
> ret=ite_gpio_irq_pending[*data];
>
> DEB(printk("ite_gpio_in_status %d ret=%d\n",*data, ret));

Nope, of course *data is >= 0, it's a u32.

Once again, the author needs to indicate (and test!) what was meant
here...

Rusty.

--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: Rusty Russell: "Re: [PATCH] 2.5.59 : drivers/char/ip2/i2lib.c"
Previous message: Rusty Russell: "re: smctr patch (with no subect)"
Next in thread: Horst von Brand: "Re: [PATCH] 2.5.59 : drivers/char/ite_gpio.c"
Reply: Horst von Brand: "Re: [PATCH] 2.5.59 : drivers/char/ite_gpio.c"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sat Feb 15 2003 - 22:00:24 EST