Re: Linux 2.5.60

From: Andrew Morton (akpm@digeo.com)
Date: Tue Feb 11 2003 - 17:47:24 EST


"Zephaniah E\. Hull" <warp@mercury.d2dc.net> wrote:
>
> Interesting BUG() on boot up.
>

The EATA driver's locking in there is so wrong I don't know how to begin to
describe it ;) Looks like a misguided cli() conversion.

Does this get you up and running?

 scsi/eata.c | 4 ----
 1 files changed, 4 deletions(-)

diff -puN drivers/scsi/eata.c~eata-detect-fix drivers/scsi/eata.c
--- 25/drivers/scsi/eata.c~eata-detect-fix 2003-02-11 14:46:21.000000000 -0800
+++ 25-akpm/drivers/scsi/eata.c 2003-02-11 14:46:37.000000000 -0800
@@ -1450,9 +1450,6 @@ static void add_pci_ports(void) {
 
 static int eata2x_detect(Scsi_Host_Template *tpnt) {
    unsigned int j = 0, k;
- unsigned long spin_flags;
-
- spin_lock_irqsave(&driver_lock, spin_flags);
 
    tpnt->proc_name = "eata2x";
 
@@ -1490,7 +1487,6 @@ static int eata2x_detect(Scsi_Host_Templ
       }
 
    num_boards = j;
- spin_unlock_irqrestore(&driver_lock, spin_flags);
    return j;
 }
 

_

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Feb 15 2003 - 22:00:36 EST