Thanks for the comments.
-----Original Message-----
From: Christoph Hellwig
To: Osamu Tomita
Cc: Linux Kernel Mailing List; Alan Cox
Sent: 2003/02/12 23:43
Subject: Re: [PATCHSET] PC-9800 subarch. support for 2.5.60 (3/34) AC#3
> On Wed, Feb 12, 2003 at 10:25:49PM +0900, Osamu Tomita wrote:
>> +ifneq ($(CONFIG_PC9800),y)
>> obj-$(CONFIG_BLK_DEV_FD) += floppy.o
>> +else
>> +obj-$(CONFIG_BLK_DEV_FD) += floppy98.o
>> +endif
>
> Please use a different config option for your floppy driver, i.e.
> CONFIG_BLK_DEV_FD98
I'll do that way.
>> +#if !defined(CONFIG_PC9800) && !defined(CONFIG_PC98)
>> +#error This driver works only for NEC PC-9800 series
>> +#endif
>
> this shoiuld be handled by the config system..
>
> > + /* Following `TAG: INITIALIZER' notations are GNU CC extension.
*/
> + flags: LP_EXIST | LP_ABORTOPEN,
> + chars: LP_INIT_CHAR,
> + time: LP_INIT_TIME,
> + wait: LP_INIT_WAIT,
> +};
>
> please use C99-style initializers here.
>> + unsigned long eflags;
>> +
>> + save_flags(eflags);
>> + cli(); /* interrupts while check is fairly bad
*/
>
> use proper spinlocking.
These 3 points are already in update patch (23/34).
And I'm working to fix other points in lp_old98.c.
I'll resend patches soon.
Thanks again,
Osamu Tomita
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Sat Feb 15 2003 - 22:00:51 EST