Re: [PATCH][2.5] flush_tlb_all is not preempt safe.

From: Zwane Mwaikambo (zwane@holomorphy.com)
Date: Fri Feb 14 2003 - 06:13:16 EST


On Fri, 14 Feb 2003, Zwane Mwaikambo wrote:

> Hi,
> Considering that smp_call_function isn't allowed to hold a lock
> reference and within smp_call_function we lock and unlock call_lock thus
> triggering a preempt point. Therefore we can't guarantee that we'll be on
> the same processor when we hit do_flush_tlb_all_local.
>
> void flush_tlb_all(void)
> {
> preempt_disable();
> smp_call_function (flush_tlb_all_ipi,0,1,1);
>
> do_flush_tlb_all_local();
> preempt_enable();
> }

Of course i had to go and paste the code i was working on. The original
isn't wrapped in preempt_disable/enable.

        Zwane (who really needs to get to bed now)

-- 
function.linuxpower.ca
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Feb 15 2003 - 22:00:53 EST