In message <20030215100424.A20365@flint.arm.linux.org.uk> you write:
> On Fri, Feb 14, 2003 at 04:37:00PM -0800, Bob Miller wrote:
> > -static void arc_inc_use_count(void)
> > +static int arc_inc_use_count(void)
> > {
> > -#ifdef MODULE
> > - MOD_INC_USE_COUNT;
> > -#endif
> > + return try_module_get(THIS_MODULE);
> > }
>
> Isn't one of the points of the module system that we don't try to run
> code inside a module without the module being reference counted?
Exactly. You can do it if you *know* you already hold a reference
count, but as a general rule it's damn suspicious.
This looks wrong,
Rusty.
-- Anyone who quotes me in their sig is an idiot. -- Rusty Russell. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Sun Feb 23 2003 - 22:00:16 EST