Re: [PATCH][2.5] IRQ distribution patch for 2.5.58

From: William Lee Irwin III (wli@holomorphy.com)
Date: Mon Feb 17 2003 - 23:15:35 EST


On Thu, Jan 16, 2003 at 01:08:55PM -0800, Kamble, Nitin A wrote:
+ spin_lock(&desc->lock);
+ irq_balance_mask[selected_irq] = target_cpu_mask;
+ spin_unlock(&desc->lock);

On Mon, 17 Feb 2003, William Lee Irwin III wrote:
>> Wrong.

On Mon, Feb 17, 2003 at 10:52:35PM -0500, Zwane Mwaikambo wrote:
> The desc locking for irq_balance_mask looks very strange, what made you
> put it in?

I only quoted the patch. I've got enough going wrong with hackers
running wild and stuffing bitmasks, ASCII art, and possibly even JPEG's
into my RTE's without changing thelocking.

-- wli
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Feb 23 2003 - 22:00:20 EST