Re: [PATCH][2.5] replace flush_map() in arch/i386/mm/pageattr.c with flush_tlb_all()

From: Dave Jones (davej@codemonkey.org.uk)
Date: Thu Feb 20 2003 - 15:50:17 EST

Next message: William Lee Irwin III: "Re: doublefault debugging (was Re: Linux v2.5.62 --- spontaneous reboots)"
Previous message: Thomas Schlichter: "Re: [PATCH][2.5] replace flush_map() in arch/i386/mm/pageattr.c with flush_tlb_all()"
In reply to: Thomas Schlichter: "Re: [PATCH][2.5] replace flush_map() in arch/i386/mm/pageattr.c with flush_tlb_all()"
Next in thread: Thomas Schlichter: "Re: [PATCH][2.5] replace flush_map() in arch/i386/mm/pageattr.c with flush_tlb_all()"
Reply: Thomas Schlichter: "Re: [PATCH][2.5] replace flush_map() in arch/i386/mm/pageattr.c with flush_tlb_all()"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Thu, Feb 20, 2003 at 09:30:55PM +0100, Thomas Schlichter wrote:

> > This looks bogus. You're killing the wbinvd() in flush_kernel_map() which
> > is needed.
> I must admit I don't exactly know the wbinvd() command, but as the comment
> says:
> /* Could use CLFLUSH here if the CPU supports it (Hammer,P4) */
>
> I thought it is not NEEDED, just a COULD...

Its hinting at a possible optimisation, not saying
that it is unneeded.

Dave

-- 
| Dave Jones.        http://www.codemonkey.org.uk
| SuSE Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: William Lee Irwin III: "Re: doublefault debugging (was Re: Linux v2.5.62 --- spontaneous reboots)"
Previous message: Thomas Schlichter: "Re: [PATCH][2.5] replace flush_map() in arch/i386/mm/pageattr.c with flush_tlb_all()"
In reply to: Thomas Schlichter: "Re: [PATCH][2.5] replace flush_map() in arch/i386/mm/pageattr.c with flush_tlb_all()"
Next in thread: Thomas Schlichter: "Re: [PATCH][2.5] replace flush_map() in arch/i386/mm/pageattr.c with flush_tlb_all()"
Reply: Thomas Schlichter: "Re: [PATCH][2.5] replace flush_map() in arch/i386/mm/pageattr.c with flush_tlb_all()"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sun Feb 23 2003 - 22:00:31 EST