Re: [PATCH] snd_pcm_oss_change_params is a stack offender

From: Andreas Dilger (adilger@clusterfs.com)
Date: Fri Feb 21 2003 - 02:58:52 EST

Next message: Oleg Drokin: "Re: Oops: nfsd/reiserfs, 2.4.20 with preemption"
Previous message: Andrew Morton: "2.5.62-mm2"
In reply to: Muli Ben-Yehuda: "[PATCH] snd_pcm_oss_change_params is a stack offender"
Next in thread: Muli Ben-Yehuda: "Re: [PATCH] snd_pcm_oss_change_params is a stack offender"
Reply: Muli Ben-Yehuda: "Re: [PATCH] snd_pcm_oss_change_params is a stack offender"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Feb 21, 2003 09:39 +0200, Muli Ben-Yehuda wrote:
> +static int alloc_param_structs(snd_pcm_hw_params_t** params,
> + snd_pcm_hw_params_t** sparams,
> + snd_pcm_sw_params_t** sw_params)

So, it looks like you've changed a large stack user into a leaker of
memory. Nowhere is the allocated memory freed, AFAICS, not upon
successful completion, nor at any of the error exits.

Cheers, Andreas

-- Andreas Dilger http://sourceforge.net/projects/ext2resize/ http://www-mddsp.enel.ucalgary.ca/People/adilger/

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Next message: Oleg Drokin: "Re: Oops: nfsd/reiserfs, 2.4.20 with preemption"
Previous message: Andrew Morton: "2.5.62-mm2"
In reply to: Muli Ben-Yehuda: "[PATCH] snd_pcm_oss_change_params is a stack offender"
Next in thread: Muli Ben-Yehuda: "Re: [PATCH] snd_pcm_oss_change_params is a stack offender"
Reply: Muli Ben-Yehuda: "Re: [PATCH] snd_pcm_oss_change_params is a stack offender"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sun Feb 23 2003 - 22:00:32 EST