Re: [PATCH] Use hex numbers in fs/block_dev.c

From: Jörn Engel (joern@wohnheim.fh-wedel.de)
Date: Wed Feb 26 2003 - 11:37:38 EST

On Wed, 26 February 2003 17:19:15 +0100, Rolf Eike Beer wrote:
>
> We're using hex numbers to identify devices in most places. We should use
> them in filesystem messages, errors etc. too, this would be much more
> consistent and avoids things like this where two different naming styles
> for the same error are used:
>
> end_request: [...] dev 16:45 (hdd), sector 9175248
> EXT3-fs error (device ide1(22,69)): [...] inode=575269, block=1146906
>
> With this patch the second message would look like this:
>
> EXT3-fs error (device ide1(16:45)): [...] inode=575269, block=1146906

Whis is _horrible_. Am I supposed to guess that ide does not use major
16, so it will be 0x16 == 22 instead?

Better use the patch below, if at all.

--- linux-2.5.63-eike/fs/block_dev.c.orig Tue Feb 25 08:15:45 2003
+++ linux-2.5.63-eike/fs/block_dev.c Wed Feb 26 16:04:28 2003
@@ -794,7 +794,7 @@
         if (!name)
                 name = "unknown-block";
 
- sprintf(buffer, "%s(%d,%d)", name, MAJOR(dev), MINOR(dev));
+ sprintf(buffer, "%s(0x%x:0x%x)", name, MAJOR(dev), MINOR(dev));
         return buffer;
 }

Jörn 

-- 
Courage is not the absence of fear, but rather the judgement that
something else is more important than fear.
-- Ambrose Redmoon
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Fri Feb 28 2003 - 22:00:36 EST