Re: [BK PATCH] PCI hotplug changes for 2.5.63

From: Linus Torvalds (torvalds@transmeta.com)
Date: Sat Mar 01 2003 - 17:00:58 EST


On Sat, 1 Mar 2003, Greg KH wrote:
>
> It looks right to me, but I don't have a working cardbus machine at the
> moment, so I can't test it, sorry.

I don't think this is right. When we unplug a device, we're unplugging it
whether it is unused or not, and pci_remove_device_safe() is the wrong
thing. It should use the "remove_behind_bridge()" thing, so I think
Russell's patch is closer to working, but that one looked like it will
certainly corrupt memory with any multi-function device, so I really would
want to see something that has actually been tested too.

                Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Mar 07 2003 - 22:00:17 EST