Re: [PATCH][2.5][CHECKER] rtc locking

From: Zwane Mwaikambo (zwane@linuxpower.ca)
Date: Sun Mar 02 2003 - 23:35:27 EST

Next message: Kai Germaschewski: "Re: fcpcipnp bug?"
Previous message: Zwane Mwaikambo: "[PATCH][2.5][CHECKER] i2c-core locking"
In reply to: William Lee Irwin III: "Re: [PATCH][2.5][CHECKER] rtc locking"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Sun, 2 Mar 2003, William Lee Irwin III wrote:

> On Sun, Mar 02, 2003 at 11:19:57PM -0500, Zwane Mwaikambo wrote:
> > Index: linux-2.5.62-numaq/drivers/char/rtc.c
> [... good patch]
>
> Do you think some kind of API safety (e.g. removing *_lock_irq() in
> favor of *_lock_irqsave()) would be worthwhile for catching these kinds
> of errors?

I think it may be worth checking *_lock_irq users period, however iirc
there is a speed argument wrt using _lock_irq since we don't save flags.

Zwane

-- 
function.linuxpower.ca
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: Kai Germaschewski: "Re: fcpcipnp bug?"
Previous message: Zwane Mwaikambo: "[PATCH][2.5][CHECKER] i2c-core locking"
In reply to: William Lee Irwin III: "Re: [PATCH][2.5][CHECKER] rtc locking"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Fri Mar 07 2003 - 22:00:19 EST