Re: [PATCH] add checkstack Makefile target

From: Arnd Bergmann (arnd@bergmann-dalldorf.de)
Date: Wed Mar 05 2003 - 20:50:22 EST


Jörn Engel wrote:

> Yet another version:
> - Arch dependent code is reduced to one regular expression.
> - Much shorter.
> - A tiny bit faster.
>
> Still, Keith' code beats the crap out of mine, speed-wise.

Ok, here is another regex for s390, including a changed $line
calculation. I didn't have ksymoops around, but this change
removes the need for it and should also speed things up.

        Arnd <><

--- checkstack.pl 2003-03-06 02:28:13.000000000 +0100
+++ scripts/checkstack.pl 2003-03-06 02:25:23.000000000 +0100
@@ -31,6 +31,9 @@
        } elsif ($arch =~ /^ppc$/) {
                #c00029f4: 94 21 ff 30 stwu r1,-208(r1)
                $re = qr/.*(stwu.*r1,-($x{3,5})\(r1\))/o;
+ } elsif ($arch =~ /^s390x?$/) {
+ # 11160: a7 fb ff 60 aghi %r15,-160
+ $re = qr/.*(ag?hi.*\%r15,-(([0-9]{2}|[3-9])[0-9]{2}))/o;
        } else {
                print "wrong or unknown architecture\n";
                exit
@@ -46,16 +49,17 @@
 #
 # main()
 #
+$funcre = qr/^$x* \<(.*)\>:$/;
 while (defined($line = <STDIN>)) {
+ if ($line =~ m/$funcre/) {
+ ($func = $line) =~ s/$funcre/\1/;
+ chomp($func);
+ }
+
        if ($line =~ m/$re/) {
- (my $addr = $line) =~ s/^($x{8}).*/0x\1/o;
+ (my $addr = $line) =~ s/^([ 0-9a-z]{8}):.*/0x\1/o;
                chomp($addr);
 
- my $ksymoops = `ksymoops -v vmlinux -m System.map -K -L -O -A $addr | \
- tail -2 | head -1`;
- (my $func = $ksymoops) =~ s/^Adhoc [0-9a-f]{8} (<.*>)/\1/;
- chomp($func);
-
                my $intro = "$addr $func:";
                my $padlen = 56 - length($intro);
                while ($padlen > 0) {
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Mar 07 2003 - 22:00:30 EST