Re: [RFC] 2.4.20-rc3 change broke NFS

From: Trond Myklebust (trond.myklebust@fys.uio.no)
Date: Tue Mar 11 2003 - 18:29:22 EST


>>>>> " " == Joe Korty <jak@rudolph.ccur.com> writes:

>> You are actually probably hitting a hole in the file. If the
>> client has written beyond the eof, but not yet transmitted the
>> data to the server, then you would indeed probably see an EIO.
>>
>> Your fix is probably correct, but could you just cross-check by
>> seeing if the appended patch also fixes the problem?

> Hi Trond, Your fix to nfs_readpage_result worked. There may be
> a small hole remaining, which the following closes. This also
> worked.

> - if (data->res.eof || page_index(page) <= inode->i_size >>
> PAGE_CACHE_SHIFT)
> + if (data->res.eof || page_index(page) <
> PAGE_CACHE_ALIGN(inode->i_size) >> PAGE_CACHE_SHIFT)

Thanks.

Cheers,
  Trond
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Mar 15 2003 - 22:00:28 EST