[patch] 2.5.64-mm8: fs/affs/dir.c doesn't compile

From: Adrian Bunk (bunk@fs.tum.de)
Date: Sun Mar 16 2003 - 06:45:45 EST

On Sun, Mar 16, 2003 at 02:42:39AM -0800, Andrew Morton wrote:
>...
> +affs-lock_kernel-fix.patch
>
> Missing an unlock_kernel(). (Why didn't any of the checkers notice this?)
>...

It seems noone tried to compile the patched file:

<-- snip -->

...
  gcc -Wp,-MD,fs/affs/.dir.o.d -D__KERNEL__ -Iinclude -Wall
-Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common
-pipe -mpreferred-stack-boundary=2 -march=k6
-Iinclude/asm-i386/mach-default -g -nostdinc -iwithprefix include
-DKBUILD_BASENAME=dir -DKBUILD_MODNAME=affs -c -o fs/affs/dir.o
fs/affs/dir.c
fs/affs/dir.c: In function `affs_readdir':
fs/affs/dir.c:81: `ret' undeclared (first use in this function)
fs/affs/dir.c:81: (Each undeclared identifier is reported only once
fs/affs/dir.c:81: for each function it appears in.)
make[2]: *** [fs/affs/dir.o] Error 1

<-- snip -->

The following patch solves it:

--- linux-2.5.64-mm8/fs/affs/dir.c.old 2003-03-16 12:39:54.000000000 +0100
+++ linux-2.5.64-mm8/fs/affs/dir.c 2003-03-16 12:43:30.000000000 +0100
@@ -78,7 +78,7 @@
         if (f_pos == 0) {
                 filp->private_data = (void *)0;
                 if (filldir(dirent, ".", 1, f_pos, inode->i_ino, DT_DIR) < 0) {
- ret = 0;
+ res = 0;
                         goto out;
                 }
                 filp->f_pos = f_pos = 1;

cu
Adrian 

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Sun Mar 23 2003 - 22:00:18 EST