Re: [CHECKER] race in 2.5.62/drivers/char/esp.c?

From: Alan Cox (alan@lxorguk.ukuu.org.uk)
Date: Sat Mar 22 2003 - 12:09:41 EST

Next message: Dominik Brodowski: "[PATCH 2.5] pcmcia (1/6): check return values of driver_register"
Previous message: Alan Cox: "IDE todo list"
In reply to: Dawson Engler: "[CHECKER] race in 2.5.62/drivers/char/esp.c?"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

> /u2/engler/mc/oses/linux/linux-2.5.62/drivers/char/esp.c:1426:rs_throttle
> cli();
> info->IER &= ~UART_IER_RDI;
> serial_out(info, UART_ESI_CMD1, ESI_SET_SRV_MASK);
> serial_out(info, UART_ESI_CMD2, info->IER);
> serial_out(info, UART_ESI_CMD1, ESI_SET_RX_TIMEOUT);
> serial_out(info, UART_ESI_CMD2, 0x00);
> sti();

> Error --->
> serial_out(info, UART_ESI_CMD1, ESI_GET_UART_STAT);
> if (serial_in(info, UART_ESI_STAT2) & UART_MSR_DCD)
> do_clocal = 1;

This is a bug yes - the CMD/STAT sequences look like they need a
spinlock to control sequence that use them. Does anyone have an esp card
any more to test stuff ?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Next message: Dominik Brodowski: "[PATCH 2.5] pcmcia (1/6): check return values of driver_register"
Previous message: Alan Cox: "IDE todo list"
In reply to: Dawson Engler: "[CHECKER] race in 2.5.62/drivers/char/esp.c?"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sun Mar 23 2003 - 22:00:41 EST