Re: [2.5 patch] fix sound/oss/ics2101.c compilation

From: Peter Waechtler (pwaechtler@mac.com)
Date: Sun Mar 23 2003 - 13:11:03 EST


Am Fre, 2003-03-21 um 21.10 schrieb Adrian Bunk:
> The following patch fixes the problem for me, please check whether it's
> correct:
>
> --- linux-2.5.65-full/sound/oss/ics2101.c.old 2003-03-21 19:13:23.000000000 +0100
> +++ linux-2.5.65-full/sound/oss/ics2101.c 2003-03-21 19:13:53.000000000 +0100
> @@ -29,7 +29,7 @@
>
> extern int *gus_osp;
> extern int gus_base;
> -extern spinlock_t lock;
> +spinlock_t lock = SPIN_LOCK_UNLOCKED;
> static int volumes[ICS_MIXDEVS];
> static int left_fix[ICS_MIXDEVS] =
> {1, 1, 1, 2, 1, 2};
>

With that patch you do not protect anything.
The write_mix function should share the spinlock used in the
interrupt handler.

Do you compile for Uniprocessor? Can you post the relevant config?
I don't get a link error with SMP.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Mar 23 2003 - 22:00:45 EST