Re: [PATCH] slab.c cleanup

From: Brian Gerst (bgerst@didntduck.org)
Date: Sun Mar 23 2003 - 16:07:37 EST

Next message: Andre Hedrick: "Re: IDE todo list"
Previous message: Manfred Spraul: "Re: [PATCH] slab.c cleanup"
In reply to: Manfred Spraul: "Re: [PATCH] slab.c cleanup"
Next in thread: Manfred Spraul: "Re: [PATCH] slab.c cleanup"
Reply: Manfred Spraul: "Re: [PATCH] slab.c cleanup"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Manfred Spraul wrote:
> Anton wrote:
>
>>> - Don't create caches that are not multiples of L1_CACHE_BYTES.
>>
>>
>> Nice idea, I often see the list walk (of the cache sizes) in kmalloc
>> in kernel
>> profiles. eg a bunch of kmalloc(2k) for network drivers.
>>
>> Since we have a 128byte cacheline on ppc64 this patch should reduce that.
>>
>>
> No, the patch is a bad thing: It means that everyone who does
> kmalloc(32,) now allocates 128 bytes, i.e. 3/4 wasted. IMHO not acceptable.

Perhaps, but it currently is already allocating 128 bytes for smaller
caches, because the cache is created with SLAB_HWCACHE_ALIGN. So we
ended up with redundantly sized caches.

-- Brian Gerst

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Next message: Andre Hedrick: "Re: IDE todo list"
Previous message: Manfred Spraul: "Re: [PATCH] slab.c cleanup"
In reply to: Manfred Spraul: "Re: [PATCH] slab.c cleanup"
Next in thread: Manfred Spraul: "Re: [PATCH] slab.c cleanup"
Reply: Manfred Spraul: "Re: [PATCH] slab.c cleanup"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sun Mar 23 2003 - 22:00:45 EST