Re: [TRIVIAL] Cleanup in fs/devpts/inode.c

From: Alex Bligh - linux-kernel (linux-kernel@alex.org.uk)
Date: Sat Mar 29 2003 - 15:14:13 EST

Next message: Shawn Starr: "[PANIC][2.5.66bk3+] run_timer_softirq - IRQ Mishandlings"
Previous message: Felipe Alfaro Solana: "Re: [TRIVIAL] Cleanup in fs/devpts/inode.c"
In reply to: john@grabjohn.com: "Re: [TRIVIAL] Cleanup in fs/devpts/inode.c"
Next in thread: john@grabjohn.com: "Re: [TRIVIAL] Cleanup in fs/devpts/inode.c"
Reply: john@grabjohn.com: "Re: [TRIVIAL] Cleanup in fs/devpts/inode.c"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

--On 29 March 2003 18:29 +0000 john@grabjohn.com wrote:

>> this patch un-complicates a small piece of code of the dev/pts
>> filesystem and decreases the size of the object code by 8 bytes
>> for my build. Yay! :)
>
>> - err = PTR_ERR(devpts_mnt);
>> - if (!IS_ERR(devpts_mnt))
>> - err = 0;
>> + if (IS_ERR(devpts_mnt))
>> + err = PTR_ERR(devpts_mnt);
>
> Why not use
>
> err = (IS_ERR(devpts_mnt) ? err = 0 : PTR_ERR(devpts_mnt));

Perhaps because it inverts the logic, and has a superfluous
assignment causing a warning? :-) I think you meant:

err = IS_ERR(devpts_mnt) ? PTR_ERR(devpts_mnt) : 0;

--
Alex Bligh
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: Shawn Starr: "[PANIC][2.5.66bk3+] run_timer_softirq - IRQ Mishandlings"
Previous message: Felipe Alfaro Solana: "Re: [TRIVIAL] Cleanup in fs/devpts/inode.c"
In reply to: john@grabjohn.com: "Re: [TRIVIAL] Cleanup in fs/devpts/inode.c"
Next in thread: john@grabjohn.com: "Re: [TRIVIAL] Cleanup in fs/devpts/inode.c"
Reply: john@grabjohn.com: "Re: [TRIVIAL] Cleanup in fs/devpts/inode.c"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Mon Mar 31 2003 - 22:00:34 EST