In part I agree. I would have preferred to make my change in one
place instead of one driver at a time. On the other hand, it seems to
me that some of these details are already spread around all the
drivers. For instance, why does every driver have to call
eth_type_trans? Could that be delayed for netif_rx ?
I do think it's reasonable for a driver to test whether the upper
layers are ready to process another packet. I suggest that this
test be encapsulated into a new function that can be changed at the
cost of only recompiling all the drivers.
David S. Miller writes:
>
> What is we change the congestion implementation? Then we'll
> have to edit every single driver. I don't think that's very
> maintainable.
>
> The whole idea is to abstract things out as far as possible so that
> the device drivers are totally agnostic about the details of the
> generic network queueing implementation.
>
> I mean, it's an interesting idea, but it exposes details that
> should not be exposed.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Wed Apr 23 2003 - 22:00:24 EST