Francois Romieu wrote:
> Greetings,
>
> I've been asked to convert the driver while compiling, so:
> - the exit paths look ok;
> - it compiles;
> - in rcpci45_remove_one(), I have been unable to find under which condition
> it would be possible to have pDpa->msgbuf set to NULL. Test removed.
>
> Comment, test and forward to Linus if correct.
Ok, I finally got around to attacking this one. Your patch looked ok to
me until I noticed one detail:
pDpa->msgbuf = kmalloc (MSG_BUF_SIZE, GFP_DMA | GFP_KERNEL);
The GFP_DMA tag indicates that we can't just use pci_alloc_consistent in
the normal way, as we lose the GFP_DMA designator.
Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Wed Apr 23 2003 - 22:00:26 EST