Re: [Announcement] "Exec Shield", new Linux security feature

From: H. Peter Anvin (hpa@zytor.com)
Date: Sun May 04 2003 - 19:41:35 EST

Next message: Adrian Bunk: "[2.5 patch] document modules_install in "make help""
Previous message: Ricardo Galli: "BUG: cpufreq_proc_read give prematures eof for /proc/cpufreq (in 2.4.x-ac and 2.5)"
In reply to: Richard Henderson: "Re: [Announcement] "Exec Shield", new Linux security feature"
Next in thread: Andi Kleen: "Re: [Announcement] "Exec Shield", new Linux security feature"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Followup to: <20030504222227.GB6808@twiddle.net>
By author: Richard Henderson <rth@twiddle.net>
In newsgroup: linux.dev.kernel
>
> On Sun, May 04, 2003 at 10:25:26AM -0400, Chuck Ebbert wrote:
> > asmlinkage int sys_iopl(unsigned long unused)
> > {
> > struct pt_regs * regs = (struct pt_regs *) &unused; <== yuck!
> [...]
> > Shouldnt it be like this?
> >
> > asmlinkage int sys_iopl (struct pt_regs regs)
>
> No, it should be like
>
> int sys_iopl (struct pt_regs *regs)
>
> and assembly language should push the proper address.
>
> The struct-as-argument form allows the compiler to
> smash the entire structure as it sees fit.
>

Hardly - it has to correspond to the ABI for the platform."

Presumably that's where the "asmlinkage" piece comes in.

-hpa

-- 
<hpa@transmeta.com> at work, <hpa@zytor.com> in private!
"Unix gives you enough rope to shoot yourself in the foot."
Architectures needed: ia64 m68k mips64 ppc ppc64 s390 s390x sh v850 x86-64
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: Adrian Bunk: "[2.5 patch] document modules_install in "make help""
Previous message: Ricardo Galli: "BUG: cpufreq_proc_read give prematures eof for /proc/cpufreq (in 2.4.x-ac and 2.5)"
In reply to: Richard Henderson: "Re: [Announcement] "Exec Shield", new Linux security feature"
Next in thread: Andi Kleen: "Re: [Announcement] "Exec Shield", new Linux security feature"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Wed May 07 2003 - 22:00:20 EST