Re: tg3 - irq #: nobody cared!

From: David S. Miller (davem@redhat.com)
Date: Tue May 06 2003 - 23:58:29 EST

Next message: Vinay K Nallamothu: "[PATCH 2.5.69] IA64 sn mod_timer fixes for kernel/mca.c"
Previous message: Paul Mackerras: "Re: [PATCH] kmalloc_percpu"
In reply to: john stultz: "tg3 - irq #: nobody cared!"
Next in thread: Andrew Morton: "Re: tg3 - irq #: nobody cared!"
Reply: Andrew Morton: "Re: tg3 - irq #: nobody cared!"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Tue, 2003-05-06 at 15:03, john stultz wrote:
> Not sure if this is the proper fix, but it stops the kernel from
> complaining. I saw Andrew suggest something similar for a sound driver.

Definitely not the right fix. If the hardware status struct
indicates no event is pending, then we return 0 since we
didn't "handle" the interrupt.

Otherwise, whats the point of the irqreturn_t at all? :-)

-- 
David S. Miller <davem@redhat.com>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: Vinay K Nallamothu: "[PATCH 2.5.69] IA64 sn mod_timer fixes for kernel/mca.c"
Previous message: Paul Mackerras: "Re: [PATCH] kmalloc_percpu"
In reply to: john stultz: "tg3 - irq #: nobody cared!"
Next in thread: Andrew Morton: "Re: tg3 - irq #: nobody cared!"
Reply: Andrew Morton: "Re: tg3 - irq #: nobody cared!"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Wed May 07 2003 - 22:00:29 EST