Re: [PATCH] fixes for linked list bugs in block I/O code

• Next message: Kai Germaschewski: "Re: The magical mystical changing ethernet interface order"
• Previous message: Karim Yaghmour: "[ANNOUNCE] embedded book / embeddedTUX.org"
• Next in thread: Dave Peterson: "Re: [PATCH] fixes for linked list bugs in block I/O code"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Wednesday 07 May 2003 06:17 pm, Bartlomiej Zolnierkiewicz wrote:
> > > Yes, but bio->bi_next is a NULL already.
> >
> > I think assuming this is bad programming form. You are assuming that
> > the memory allocator zeros out newly allocated memory. Though your
>
> No, it is not memory allocator but block layer.
> Look at bio_init(), there is bio->bi_next = NULL explicitly.

Ok, I agree: the patch is not needed for 2.5 (although I think it still
makes sense for 2.4.20). Thanks for the correction.

-Dave
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

• Next message: Kai Germaschewski: "Re: The magical mystical changing ethernet interface order"
• Previous message: Karim Yaghmour: "[ANNOUNCE] embedded book / embeddedTUX.org"
• Next in thread: Dave Peterson: "Re: [PATCH] fixes for linked list bugs in block I/O code"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Thu May 15 2003 - 22:00:28 EST